Modernize property definitions in SplitText#604
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #604 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 6 6
Lines 773 773
=======================================
Hits 762 762
Misses 11 11 ☔ View full report in Codecov by Sentry. |
|
To be fully backwards compatible I'm against removing methods (even if they are private) for the 4.5.0 release. Do we need to mention them in the change log? |
These methods only exist to implement the property and were introduced at the same time as the property, in commit 8515734. There was never a reason to call the private method over using the public property. If you're thinking of subclasses that might override the method, that doesn't actually work: the property definition captures the method from the class scope. It doesn't do a lookup on |
This code was using old property syntax instead of
@propertydecorators.I also removed the comments, as they don't express anything that isn't already clear from the code itself.