MonitorField - Change default to None when the field is nullable#599
Merged
foarsitter merged 2 commits intojazzband:masterfrom Apr 4, 2024
Merged
Conversation
ce8406a to
1ec8f47
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #599 +/- ##
==========================================
- Coverage 98.94% 98.94% -0.01%
==========================================
Files 6 6
Lines 760 757 -3
==========================================
- Hits 752 749 -3
Misses 8 8 ☔ View full report in Codecov by Sentry. |
…lable and no default is provided
1ec8f47 to
5eab41f
Compare
Contributor
|
@gmcrocetti can you rebase this PR? Then I will merge it. |
…monitor-field-new-default
Contributor
Author
|
Just did it @foarsitter . Thanks ! :) |
Contributor
|
Thanks @gmcrocetti |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MonitorField's default value isdjango.utils.timezone.noweven whennull=True. This behavior is misleading and should be changed. Despite that, some users might rely on this very same behavior and that's why #577 introduced a deprecation warning when such behavior is encountered.The goal of this PR is make the field use
Noneas default when initialized withnull=Trueand without a default - of course the provided argument fordefaulttakes precedence.Original discussion in #100
Solution
Remove the deprecation warning introduced in #577 and implement the desired behavior: use
Nonewhen the field is nullable and no default is provided.This change requires a major release (
5.x.x) as discussed with @foarsitter in #577 .Commandments
CHANGES.rstfile to describe the changes, and quote according issue withGH-<issue_number>.