Resolve name clash among test models#596
Merged
foarsitter merged 1 commit intojazzband:masterfrom Mar 22, 2024
Merged
Conversation
There were two classes named `StatusCustomManager`: the first is an actual manager, the second a status model that uses a custom manager. The latter is renamed to `CustomManagerStatusModel` in this commit.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #596 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 6 6
Lines 773 773
=======================================
Hits 762 762
Misses 11 11 ☔ View full report in Codecov by Sentry. |
foarsitter
approved these changes
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
tests/models.py, there were two classes namedStatusCustomManager: the first is an actual manager, the second a status model that uses a custom manager. The latter is renamed toCustomManagerStatusModelin this PR.The name clash tripped up mypy, but is also confusing for human readers.