Explicitly re-export names from __init__ module#591
Merged
foarsitter merged 1 commit intojazzband:masterfrom Mar 22, 2024
Merged
Explicitly re-export names from __init__ module#591foarsitter merged 1 commit intojazzband:masterfrom
__init__ module#591foarsitter merged 1 commit intojazzband:masterfrom
Conversation
Both mypy and flake8 understand `__all__`, removing the need for warning suppression comments.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #591 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 6 6
Lines 772 773 +1
=======================================
+ Hits 761 762 +1
Misses 11 11 ☔ View full report in Codecov by Sentry. |
foarsitter
approved these changes
Mar 22, 2024
Contributor
|
I like the gradual improvements, thanks @mthuurne |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By listing names intended for export in the
__all__module-level variable, static code checkers like mypy are able to verify that importing a name from a module that itself imported it is by design rather than by accident.As flake8 understand
__all__, this also removes the need for warning suppression comments.