Levels variable is never set#590
Merged
foarsitter merged 1 commit intojazzband:masterfrom Apr 3, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #590 +/- ##
==========================================
+ Coverage 98.56% 98.94% +0.37%
==========================================
Files 6 6
Lines 768 760 -8
==========================================
- Hits 757 752 -5
+ Misses 11 8 -3 ☔ View full report in Codecov by Sentry. |
gmcrocetti
approved these changes
Apr 3, 2024
Contributor
gmcrocetti
left a comment
There was a problem hiding this comment.
Hi @foarsitter.
The change looks solid.
I investigated a bit about the reasoning of those changes and the majority of it was introduced by two PRs / commits:
They date back to 10 years ago and it targeted Django < 2.
Also, changes look consistent with git grep levels:
All that to say LGTM, nice job.
Contributor
Author
|
@gmcrocetti thanks for checking out. Wasn't confided enough to merge it by my own so thanks for your approval! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking into the uncovered lines of code (at this moment 757 out of 768 lines are covered) I noticed that the
levelsvariable inmanagers.pyis never being set apart fromNone.According to the test-suite it can be removed safely.
Can someone review this removal?