Remove dead init_deferred_fields method#580
Merged
foarsitter merged 1 commit intojazzband:masterfrom Mar 21, 2024
joecox:remove-dead-tracker-code
Merged
Remove dead init_deferred_fields method#580foarsitter merged 1 commit intojazzband:masterfrom joecox:remove-dead-tracker-code
init_deferred_fields method#580foarsitter merged 1 commit intojazzband:masterfrom
joecox:remove-dead-tracker-code
Conversation
Contributor
Author
|
Given that this is removal of dead code, which doesn't affect any documented feature, I opted not to update CHANGES.rst. I can do that if needed. |
foarsitter
approved these changes
Mar 21, 2024
Contributor
|
Thanks @joecox |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
init_deferred_fieldsmethod, added in 6ffae1a, had its only usage removed in e6c7b56.Solution
Remove the
init_deferred_fieldsmethod, along with the now-unusedDescriptorMixin.Commandments
CHANGES.rstfile to describe the changes, and quote according issue withGH-<issue_number>.