fix: Use proper column name instead of attname#573
Merged
foarsitter merged 4 commits intojazzband:masterfrom Jun 16, 2023
Merged
fix: Use proper column name instead of attname#573foarsitter merged 4 commits intojazzband:masterfrom
foarsitter merged 4 commits intojazzband:masterfrom
Conversation
From django comment in db/models/fields/__init__.py: # A guide to Field parameters: # # * name: The name of the field specified in the model. # * attname: The attribute to use on the model object. This is the same as # "name", except in the case of ForeignKeys, where "_id" is # appended. # * db_column: The db_column specified in the model (or None). # * column: The database column for this field. This is the same as # "attname", except if db_column is specified. # # Code that introspects values, or does other dynamic things, should use # attname. For example, this gets the primary key value of object "obj": # # getattr(obj, opts.pk.attname)
Contributor
|
Do you think you can provide a test-case for the scenario you are describing? |
Contributor
Author
|
Sure, updated test cases. |
Contributor
|
Thanks for providing a test case. I confirmed the issue and fix locally. Can you update |
foarsitter
approved these changes
Jun 16, 2023
Codecov Report
@@ Coverage Diff @@
## master #573 +/- ##
=======================================
Coverage 95.12% 95.12%
=======================================
Files 6 6
Lines 820 820
=======================================
Hits 780 780
Misses 40 40
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
Thanks for your time and contribution @last-partizan! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From django comment in
db/models/fields/__init__.py:Problem
Currently there is not problem, unless someone used
db_columnon their parent link field.Solution
This changes attribute name following django recommendations.