Update where ConnectionDoesNotExist is imported from#566
Merged
foarsitter merged 1 commit intojazzband:masterfrom Mar 21, 2024
Merged
Update where ConnectionDoesNotExist is imported from#566foarsitter merged 1 commit intojazzband:masterfrom
ConnectionDoesNotExist is imported from#566foarsitter merged 1 commit intojazzband:masterfrom
Conversation
ConnectionDoesNotExist is imported from
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #566 +/- ##
=======================================
Coverage 98.56% 98.56%
=======================================
Files 6 6
Lines 768 768
=======================================
Hits 757 757
Misses 11 11 ☔ View full report in Codecov by Sentry. |
foarsitter
reviewed
Mar 21, 2024
It was moved to a different package in Django 3.2.
3fef7cd to
a1530ad
Compare
foarsitter
approved these changes
Mar 21, 2024
Contributor
|
Thanks @mthuurne |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ConnectionDoesNotExistdoes not exist indjango.db.utilsindjango-stubs, as it was moved todjango.utils.connectionin Django 3.2. At some point in the future, I expect it will also only be available from its new location in Django itself.Solution
Import it from its new location.
Commandments
CHANGES.rstfile to describe the changes, and quote according issue withGH-<issue_number>.