Remove workaround from select_subclasess()#524
Merged
hramezani merged 1 commit intojazzband:masterfrom Aug 17, 2022
Merged
Conversation
The workaround was for an issue that was fixed in Django 1.7: https://code.djangoproject.com/ticket/16855 / django/django@349c12d .
Codecov Report
@@ Coverage Diff @@
## master #524 +/- ##
==========================================
- Coverage 95.15% 95.12% -0.03%
==========================================
Files 6 6
Lines 825 820 -5
==========================================
- Hits 785 780 -5
Misses 40 40
Continue to review full report at Codecov.
|
hramezani
approved these changes
Aug 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The workaround was for an issue that was fixed in Django 1.7: https://code.djangoproject.com/ticket/16855 / django/django@349c12d .
Solution
Remove workaround.
Commandments
CHANGES.rstfile to describe the changes, and quote according issue withGH-<issue_number>.