Allow running tests using sqlite#516
Merged
foarsitter merged 2 commits intojazzband:masterfrom Mar 21, 2024
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #516 +/- ##
=======================================
Coverage 95.15% 95.15%
=======================================
Files 6 6
Lines 825 825
=======================================
Hits 785 785
Misses 40 40 Continue to review full report at Codecov.
|
auvipy
reviewed
Dec 26, 2021
tests/settings.py
Outdated
| else: | ||
| DATABASES = { | ||
| "default": { | ||
| "ENGINE": "django.db.backends.postgresql_psycopg2", |
Contributor
There was a problem hiding this comment.
"django.db.backends.postgresql_psycopg2", should be just postgresql as per new django releases
Member
Author
There was a problem hiding this comment.
Yup, that will work dj2.2+ ; will update..
Member
Author
|
ping @auvipy. I can merge but would be bad practise IMO. |
foarsitter
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Distro build workers do not want to install postgres in order to run the tests.
Solution
Added capability to use sqlite instead using env flag
SQLITECommandments
CHANGES.rstfile to describe the changes, and quote according issue withGH-<issue_number>.