Switch from freezegun to time-machine.#510
Merged
foarsitter merged 2 commits intojazzband:masterfrom Mar 22, 2024
Merged
Conversation
a0aeaab to
1d9a39e
Compare
foarsitter
approved these changes
Mar 21, 2024
Contributor
|
Thanks @adamchainz |
Contributor
|
@adamchainz I will have to revert this PR since it breaks the tests. Do you have any clue what's going wrong? |
Merged
Contributor
|
Setting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
freezegun is slow.
Solution
time-machine is more accurate and faster.
Commandments
CHANGES.rstfile to describe the changes, and quote according issue withGH-<issue_number>.