Add tests for field tracker methods in save method#147
Closed
treyhunner wants to merge 1 commit intomasterfrom
Closed
Add tests for field tracker methods in save method#147treyhunner wants to merge 1 commit intomasterfrom
treyhunner wants to merge 1 commit intomasterfrom
Conversation
Collaborator
|
The approach is a bit cleverer than I probably would have implemented, but I think it's reasonable. Of the two cases broken by #130, though, I think this tests only the less-important one, using What is guaranteed in the documentation, but was also broken by #130, and is also untested, is using |
Merged
|
I am closing this while we are reworking the FieldTracker feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests verify that
FieldTrackermethods work as expected inside thesave()method of a model.I used a Django signal to inject assertions into a model's
save()method and I used a context manager to handle the repetitive signal connecting/disconnecting. Let me know if you think this approach is overkill.When I cherry-pick 3496fe4 (from #130) onto these changes and run the tests, three of the four tests fail (the .current() function works properly still).