set 'Content-Length' automaticly#41
Closed
cjqpker wants to merge 1 commit intojayjamesjay:masterfrom
cjqpker:patch-1
Closed
set 'Content-Length' automaticly#41cjqpker wants to merge 1 commit intojayjamesjay:masterfrom cjqpker:patch-1
cjqpker wants to merge 1 commit intojayjamesjay:masterfrom
cjqpker:patch-1
Conversation
Set 'Content-Length' automaticly when set body into request This setting is suit for most scenarios, and sure you can set it back to zero if needed.
Owner
|
This can be useful in many cases but I think sometimes it can lead to unexpected behaviors such as you first set header In my humble opinion implementing higher level abstraction just for sending Please let me know what you think and also please take a look at commit add post fn. |
Author
|
Set header Content-Length to the actual length of body is more common, in my opinion, and user can set it again if there is some special usecase, which may not be often |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set 'Content-Length' automaticly when set body into request
This setting is suit for most scenarios, and sure you can set it back to zero if needed.