Remove redundant Node.js version compatibility logic #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-marcacci
approved these changes
Jan 16, 2020
Collaborator
mike-marcacci
left a comment
There was a problem hiding this comment.
Woohoo!! So happy to get to this place :)
I think this looks good from the perspective of this library. Now that we only support node 10+ we can upgrade to fs-capacitor@5 which is API-compatible with fs-capacitor@4 but without the extra logic (and a large dependency) required to support node 8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes now redundant Node.js version compatibility logic in the
processRequestfunction. Now we have 100% code coverage without ignored lines 🎉@mike-marcacci can you think of anything else that can be simplified?