Support clientAwareness being undefined in Apollo Link context#212
Merged
jaydenseric merged 1 commit intojaydenseric:masterfrom Jul 28, 2020
Merged
Conversation
Owner
|
Thanks for the PR! I did have it that way originally, but then the when adding code coverage realized it was never necessary when used with Apollo Client. I did try to research instances where it may be undefined in context, but couldn't find any examples so I removed the default. |
jaydenseric
requested changes
Jul 28, 2020
Owner
jaydenseric
left a comment
There was a problem hiding this comment.
Could you please add a test for this, so we can get back to 100% code coverage? Also, we need to add a changelog entry under "Patch".
81900d5 to
0beacb1
Compare
Contributor
Author
|
@jaydenseric All set :) |
jaydenseric
requested changes
Jul 28, 2020
0beacb1 to
aab6052
Compare
jaydenseric
requested changes
Jul 28, 2020
aab6052 to
a19b3b8
Compare
Owner
|
This change has been published in v14.1.1 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a small tweak that ensures
createUploadLinkdoesn't break ifclientAwarenessis undefined.clientAwarenesswill always be defined when using a link through an ApolloClient instance, but may be undefined in other contexts (like if callingexecutedirectly instead), so we shouldn't assume it will always be defined.