Skip to content

@apollo/client should be a peer dependency #251

Closed
#252
Closed
@apollo/client should be a peer dependency#251
#252
@andreialecu

Description

@andreialecu
andreialecu
opened on Mar 30, 2021

It doesn't seem to be correct that @apollo/client is a regular dependency.

apollo-upload-client/src/public/createUploadLink.js

Lines 3 to 12 in 6dec8ed

const { ApolloLink, Observable } = require('@apollo/client/core');
const {
createSignalIfSupported,
fallbackHttpConfig,
parseAndCheckHttpResponse,
rewriteURIForGET,
selectHttpOptionsAndBody,
selectURI,
serializeFetchParameter,
} = require('@apollo/client/link/http');

Instead, it should be in peerDependencies.

I noticed this while exploring an app's dependencies, and I noticed that @apollo/client was included twice in the resulting installation.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions