[gpu] Use batched syev for lax.linalg.eigh#31375
Merged
copybara-service[bot] merged 1 commit intojax-ml:mainfrom Sep 10, 2025
Merged
[gpu] Use batched syev for lax.linalg.eigh#31375copybara-service[bot] merged 1 commit intojax-ml:mainfrom
copybara-service[bot] merged 1 commit intojax-ml:mainfrom
Conversation
Collaborator
|
This LGTM. Do you also want to change the C++ code to select jacobi always when passed "default" as the algorithm? |
Collaborator
|
There are some test failures. PTAL? Most look like small tolerance bumps but e.g. the rank deficient one seems large. |
e7590e9 to
370da03
Compare
a538331 to
3ed5f81
Compare
Use syevBatched for eigh
3ed5f81 to
158d4bd
Compare
hawkinsp
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let us use a batched syev for
jax.lax.linalg.eighto speed up the functionfor non-trivial batch sizes.
Fixes #31368
Depends on openxla/xla#30810