fix: handle wildcard actualType in matchTypeParameters (issue #3751)#5029
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5029 +/- ##
===============================================
- Coverage 58.693% 58.686% -0.008%
Complexity 2595 2595
===============================================
Files 702 702
Lines 40277 40282 +5
Branches 7340 7342 +2
===============================================
Hits 23640 23640
- Misses 13663 13667 +4
- Partials 2974 2975 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3751 .
When Stream.collect() is called with a Collector whose intermediate
accumulation type is a wildcard (e.g. Collectors.toList() returns
Collector<T, ?, List>), matchTypeParameters threw
UnsupportedOperationException trying to bind the formal type variable
'A' against the wildcard '?'.
Apply capture-conversion rules: a bounded wildcard (? extends / ? super)
contributes its declared bound as the inferred type; an unbounded wildcard
'?' carries no type information and is skipped. This leaves 'A' unresolved
while still allowing the return type 'R' to be correctly inferred from the
remaining type arguments.
Add Javadoc to matchTypeParameters documenting all handled cases.
Add two regression tests in MethodCallExprContextResolutionTest:
calculateResolvedTypefor method call toStream.collect#3751)