fix: resolve NameExpr to field when local variable with same name is declared later#5025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5025 +/- ##
===============================================
- Coverage 58.709% 58.699% -0.010%
+ Complexity 2593 2587 -6
===============================================
Files 702 702
Lines 40232 40213 -19
Branches 7331 7325 -6
===============================================
- Hits 23620 23605 -15
+ Misses 13638 13636 -2
+ Partials 2974 2972 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3674 .
BlockStmtContext.solveSymbol() was using the last statement of the block
as the reference point for localVariablesExposedToChild(), which exposed
all local variables declared anywhere in the block — including ones
declared after the expression being resolved. This caused a NameExpr
referring to a class field to be incorrectly resolved to a local variable
with the same name declared later in the same method.
The fix removes the solveSymbol() override entirely. StatementContext
(the parent class) already handles both cases correctly: direct child
statements walk backwards through the block and delegate to the method
context, while nested blocks use the NodeWithStatements branch to walk
backwards from their own position in the outer block.