fix: resolve constructor parameter type for lambda in ObjectCreationExpr#5024
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5024 +/- ##
===============================================
+ Coverage 58.701% 58.709% +0.008%
- Complexity 2592 2593 +1
===============================================
Files 702 702
Lines 40224 40232 +8
Branches 7329 7331 +2
===============================================
+ Hits 23612 23620 +8
+ Misses 13641 13638 -3
- Partials 2971 2974 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3626 .
When a LambdaExpr is passed as an argument to a constructor
(e.g.
new Thread(() -> ...)), TypeExtractor.visit(LambdaExpr)was calling
expr.getType().resolve()on the ObjectCreationExpr,which returned the type of the constructed object (e.g. Thread)
instead of the functional-interface type expected at that
constructor parameter position (e.g. Runnable).
Because Thread is not itself a functional interface, resolveLambda()
could not find a functional method on it, producing a wrong result.
The fix mirrors the existing MethodCallExpr handling: look up the
argument position of the lambda, resolve the constructor via
facade.solve(expr), then call
MethodResolutionLogic.getMethodsExplicitAndVariadicParameterType()
on the ResolvedConstructorDeclaration (which extends
ResolvedMethodLikeDeclaration) to obtain the correct parameter type.
Two regression tests are added to LambdaResolutionTest:
new Thread(() -> ...) → java.lang.Runnable
new MyTask(() -> 42) → MyTask.Task