fix(FunctionalInterfaceLogic): return empty() for non-reference types (#3625)#5022
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5022 +/- ##
===============================================
- Coverage 58.704% 58.701% -0.003%
Complexity 2592 2592
===============================================
Files 702 702
Lines 40222 40224 +2
Branches 7329 7329
===============================================
Hits 23612 23612
- Misses 13639 13641 +2
Partials 2971 2971
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3625.
getFunctionalMethod(ResolvedType) called asReferenceType() unconditionally,
throwing UnsupportedOperationException when the type was not a reference type
(e.g. ResolvedArrayType, ResolvedPrimitiveType).
Per JLS §9.8, a functional interface is always an interface, which is a
reference type. Arrays and primitives can therefore never be functional
interfaces, so returning Optional.empty() for them is semantically correct.
Fix: move the isReferenceType() guard to the top of the method, before any
call to asReferenceType(). The now-redundant isReferenceType() condition on
the inner if-statement is removed as a consequence.
Add two regression tests covering ResolvedPrimitiveType and ResolvedArrayType
to prevent future regressions.