Fix lambda type inference for fully-qualified static method calls (#3476#5019
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5019 +/- ##
===============================================
- Coverage 58.711% 58.704% -0.008%
Complexity 2592 2592
===============================================
Files 702 702
Lines 40217 40222 +5
Branches 7327 7329 +2
===============================================
Hits 23612 23612
- Misses 13634 13639 +5
Partials 2971 2971
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3476 .
MethodResolutionLogic.inferTypes() did not handle subtype relationships: when matching ArrayList against List, the differing qualified names caused the method to return immediately without inferring T = String. This left lambda parameters typed as LambdaConstraintType{bound=TypeVariable} instead of LambdaConstraintType{bound=String}, breaking resolution of any method call inside the lambda.
The fix walks the ancestors of the source type to find a matching supertype when qualified names differ, consistent with the existing approach in InferenceContext.registerCorrespondance().
Only triggered via the FieldAccessExpr code path (fully-qualified class name); the NameExpr path (imported class) already used matchTypeParameters() which handled subtypes correctly.