Fix parsing of multiple patterns in switch case labels (issue #4996)#5009
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5009 +/- ##
===========================================
Coverage 58.694% 58.694%
Complexity 2592 2592
===========================================
Files 700 700
Lines 40188 40188
Branches 7323 7323
===========================================
Hits 23588 23588
Misses 13630 13630
Partials 2970 2970
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4996 .
The JavaCC grammar only allowed a single PatternExpression per case label,
causing a parse error on valid Java 22+ syntax such as:
case String _, Integer _ -> ...
Extended the SwitchEntry grammar rule to accept one or more comma-separated
PatternExpression nodes using a targeted LOOKAHEAD to avoid ambiguity with
the existing multi-constant case branch (case A, B ->).