fix(grammar): allow empty component list in RecordPattern#5008
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5008 +/- ##
===============================================
+ Coverage 58.657% 58.694% +0.036%
- Complexity 2564 2592 +28
===============================================
Files 699 700 +1
Lines 40121 40188 +67
Branches 7314 7323 +9
===============================================
+ Hits 23534 23588 +54
- Misses 13620 13630 +10
- Partials 2967 2970 +3
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per JLS 14.30, the component list in a RecordPattern is optional:
RecordPattern: ReferenceType ( [ComponentPatternList] )
The PatternList() production in java.jj required at least one
component, causing a parse error on valid patterns like Point()
or case Pair() in switch expressions.
Wrap the content of PatternList() in an optional block [ ... ]
so that an empty parenthesised list produces an empty NodeList
rather than a parse failure. Also update the Javadoc comment to
match the JLS definition.
Add emptyRecordPatternListShouldWork() test to PatternExprTest
to cover the zero-component case.