Skip to content

Add comprehensive test suite for lexical preserving printer rules#4957

Merged
jlerbsc merged 1 commit into
javaparser:masterfrom
jlerbsc:lpp_refactor_difference
Jan 21, 2026
Merged

Add comprehensive test suite for lexical preserving printer rules#4957
jlerbsc merged 1 commit into
javaparser:masterfrom
jlerbsc:lpp_refactor_difference

Conversation

@jlerbsc

@jlerbsc jlerbsc commented Jan 21, 2026

Copy link
Copy Markdown
Collaborator

Adds 71+ unit tests covering all 58 rules identified in Difference.apply():

  • 22 REMOVED rules (node/token removal, indentation cleanup)
  • 21 KEPT rules (AST/token synchronization, type preservation)
  • 13 ADDED rules (insertion with indentation management)
  • 7 LEFTOVER rules (end-of-processing edge cases)

Tests organized in 4 classes inheriting AbstractLexicalPreservingTest.
Some tests disabled due to known indentation bugs (e.g., adding statement
at beginning of block). Serves as specification for future refactoring.

@codecov

codecov Bot commented Jan 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.657%. Comparing base (babcc9c) to head (2146cfc).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##              master     #4957       +/-   ##
===============================================
+ Coverage     58.637%   58.657%   +0.019%     
  Complexity      2564      2564               
===============================================
  Files            699       699               
  Lines          40121     40121               
  Branches        7314      7314               
===============================================
+ Hits           23526     23534        +8     
+ Misses         13628     13620        -8     
  Partials        2967      2967               
Flag Coverage Δ
AlsoSlowTests 58.657% <ø> (+0.019%) ⬆️
javaparser-core 58.657% <ø> (+0.019%) ⬆️
javaparser-symbol-solver 58.657% <ø> (+0.019%) ⬆️
jdk-10 58.226% <ø> (+0.017%) ⬆️
jdk-11 58.228% <ø> (+0.019%) ⬆️
jdk-12 58.228% <ø> (+0.022%) ⬆️
jdk-13 58.228% <ø> (+0.019%) ⬆️
jdk-14 58.460% <ø> (+0.019%) ⬆️
jdk-15 58.460% <ø> (+0.019%) ⬆️
jdk-16 58.435% <ø> (+0.022%) ⬆️
jdk-17 58.584% <ø> (+0.019%) ⬆️
jdk-18 58.584% <ø> (+0.019%) ⬆️
jdk-8 58.062% <ø> (+0.017%) ⬆️
jdk-9 58.224% <ø> (+0.017%) ⬆️
macos-latest 58.632% <ø> (+0.002%) ⬆️
ubuntu-latest 58.627% <ø> (+0.002%) ⬆️
windows-latest 58.640% <ø> (+0.019%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2ed341...2146cfc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jlerbsc jlerbsc merged commit 27b0422 into javaparser:master Jan 21, 2026
34 of 35 checks passed
@jlerbsc jlerbsc added this to the next release milestone Jan 21, 2026
@jlerbsc jlerbsc added the PR - TESTCASE Pull requests with this label are test cases only - may later be merged when it passes. label Jan 21, 2026
@jlerbsc jlerbsc deleted the lpp_refactor_difference branch January 21, 2026 17:19
@jlerbsc jlerbsc changed the title Add comprehensive test suite for Difference.apply() rules Add comprehensive test suite for lexical reserving printer rules Jan 21, 2026
@jlerbsc jlerbsc changed the title Add comprehensive test suite for lexical reserving printer rules Add comprehensive test suite for lexical preserving printer rules Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR - TESTCASE Pull requests with this label are test cases only - may later be merged when it passes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant