refactor(lexicalpreservation): introduce TextElementSequence API and migrate core classes#4955
Merged
Conversation
jlerbsc
commented
Jan 20, 2026
Collaborator
- Create TextElementSequence interface with specialized search/filtering operations (findFirst, findLast, takeWhile, anyMatch, allMatch, noneMatch)
- Implement TextElementList with optimized index-based operations and method chaining support
- Introduce TextElementIterator for bidirectional traversal with currentIndex() tracking
- Replace IndexTrackingIterator with generic implementation, removing ArrayIterator
- Migrate Difference.java: refactor processIndentation(), posOfNextComment(), removeElements() (-96 lines, ~8% reduction)
- Migrate NodeText.java to use TextElementList internally (code simplification, -16% logic, -25% complexity)
- Add factory method TextElementList.of(List) for fluent API chaining
- Distinguish toList() (unmodifiable) from toMutableList() (mutable) for clear intent
- Fix indentation preservation bugs and iterator edge cases
…migrate core classes
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4955 +/- ##
===============================================
+ Coverage 58.459% 58.574% +0.114%
Complexity 2564 2564
===============================================
Files 692 696 +4
Lines 39891 39980 +89
Branches 7261 7274 +13
===============================================
+ Hits 23320 23418 +98
+ Misses 13619 13611 -8
+ Partials 2952 2951 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.