Fix: Issue 4829 Infinite loop in DifferenceElementCalculator when calling setPermittedTypes#4834
Merged
Merged
Conversation
…ling setPermittedTypes
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4834 +/- ##
===============================================
+ Coverage 58.335% 58.355% +0.019%
Complexity 2518 2518
===============================================
Files 671 671
Lines 38808 38821 +13
Branches 7053 7056 +3
===============================================
+ Hits 22639 22654 +15
- Misses 13284 13285 +1
+ Partials 2885 2882 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The algorithm that calculates the differences in representation of a node following a change has exponential complexity when we remove the permits clause. One solution is to add memoisation to eliminate recalculations. This reduces the complexity to O(n*m).
Fixes #4829 .