Fix: issue 4747 Lexical preserving fails after replacing MarkerAnnotationExpr name#4748
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4748 +/- ##
===============================================
+ Coverage 58.287% 58.324% +0.036%
Complexity 2509 2509
===============================================
Files 671 671
Lines 38761 38764 +3
Branches 7033 7034 +1
===============================================
+ Hits 22593 22609 +16
+ Misses 13276 13264 -12
+ Partials 2892 2891 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4747 .
This happens because changing a name results in the creation of a token when the syntax of the modified node is evaluated, whereas parsing an annotation results in a representation containing a child node (representing the annotation name). When the annotation name is modified, the element to be deleted (the child node) is compared with the token containing the character string representing the new annotation name.