Skip to content

Fixed return within void method#4587

Merged
jlerbsc merged 7 commits into
javaparser:masterfrom
Universe-E:Issue2962
Oct 23, 2024
Merged

Fixed return within void method#4587
jlerbsc merged 7 commits into
javaparser:masterfrom
Universe-E:Issue2962

Conversation

@Universe-E

@Universe-E Universe-E commented Oct 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fixes #2962

Solved the problem of an incorrect return statement in a void method in the LambdaVoid.java sample file and updates the corresponding test case in LambdaResolutionTest.java.

Changes

  • Modified the LambdaVoid.java file to remove the incorrect return statement and use the correct lambda syntax
  • Updated the typeOfVoidLambda test method in LambdaResolutionTest.java to correctly test the modified sample code
  • Fixed line ending issues in test resources files by ensuring consistent LF line endings

Results

  • The project compiles normally after these changes
  • The typeOfVoidLambda test passes and correctly identifies the lambda expression type as Consumer
  • All test resource files now have consistent line endings (LF)

@codecov

codecov Bot commented Oct 22, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.009%. Comparing base (5acfba9) to head (7851e36).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #4587   +/-   ##
=========================================
  Coverage   58.009%   58.009%           
=========================================
  Files          508       508           
  Lines        29778     29778           
  Branches      5253      5253           
=========================================
  Hits         17274     17274           
  Misses       10366     10366           
  Partials      2138      2138
Flag Coverage Δ
AlsoSlowTests 58.009% <ø> (ø)
javaparser-core 58.009% <ø> (ø)
javaparser-symbol-solver 58.009% <ø> (ø)
jdk-10 57.962% <ø> (ø)
jdk-11 57.975% <ø> (ø)
jdk-12 57.962% <ø> (ø)
jdk-13 57.975% <ø> (ø)
jdk-14 57.962% <ø> (ø)
jdk-15 57.975% <ø> (ø)
jdk-16 57.975% <ø> (ø)
jdk-17 57.975% <ø> (ø)
jdk-18 57.975% <ø> (ø)
jdk-8 57.978% <ø> (ø)
jdk-9 57.962% <ø> (ø)
macos-latest 57.999% <ø> (ø)
ubuntu-latest 57.985% <ø> (ø)
windows-latest 57.985% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e6b7be...7851e36. Read the comment docs.

@jlerbsc

jlerbsc commented Oct 22, 2024

Copy link
Copy Markdown
Collaborator

You must use spotless:apply to resolve code formatting issues.

@jlerbsc jlerbsc merged commit cabdd24 into javaparser:master Oct 23, 2024
@jlerbsc jlerbsc added this to the next release milestone Oct 23, 2024
@jlerbsc jlerbsc added the PR: Fixed A PR that offers a fix or correction label Oct 23, 2024
@jlerbsc

jlerbsc commented Oct 23, 2024

Copy link
Copy Markdown
Collaborator

Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Fixed A PR that offers a fix or correction

Projects

None yet

Milestone

3.26.3

Development

Successfully merging this pull request may close these issues.

Double check test case - return within a void method

2 participants

@Universe-E @jlerbsc