Add link to the guide to adding nodes in CONTRIBUTING.md#4453
Merged
jlerbsc merged 2 commits intoJun 4, 2024
Conversation
Collaborator
|
Thank you for this guide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote this as a walkthrough for the changes I made in #4432 and I think this guide would be useful for future contributors who want to add support for new Java features.
CONTRIBUTING.mdalready has a link to the wiki, but I think it's worth adding a specific mention of this page since it mentions all of the majorJavaParsercomponents and is a fairly comprehensive overview of what's required when adding new nodes.