Fix "record" as non-type identifier in Java 16#3362
Merged
Conversation
Contributor
Author
|
I added |
This was referenced Sep 2, 2021
Member
|
Tests appear to be failing due to the Java 15 (preview) validator tests -- note that records were in preview for both Java 14 and Java 15 before being available in Java 16 👍
|
MysterAitch
reviewed
Sep 3, 2021
MysterAitch
reviewed
Sep 3, 2021
MysterAitch
reviewed
Sep 3, 2021
MysterAitch
reviewed
Sep 3, 2021
MysterAitch
reviewed
Sep 3, 2021
MysterAitch
reviewed
Sep 3, 2021
Member
|
I think this is good to merge, just a few bits about naming to update -- thank you @koppor 👍 |
Codecov Report
@@ Coverage Diff @@
## master #3362 +/- ##
===============================================
+ Coverage 57.328% 57.335% +0.007%
Complexity 2576 2576
===============================================
Files 620 621 +1
Lines 34297 34312 +15
Branches 5808 5809 +1
===============================================
+ Hits 19662 19673 +11
- Misses 12668 12670 +2
- Partials 1967 1969 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
MysterAitch
reviewed
Sep 8, 2021
| class Java15PreviewValidatorTest { | ||
|
|
||
| private final JavaParser javaParser = new JavaParser(new ParserConfiguration().setLanguageLevel(JAVA_16)); | ||
| private final JavaParser javaParser = new JavaParser(new ParserConfiguration().setLanguageLevel(JAVA_15_PREVIEW)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details at #3366.
Following statement is a valid statement in Java:
This PR creates a test for it and tries to provide a fix.