Continue investigating migration to Jetty 12#2381
Conversation
…red information is use current accessors
|
One of the problems is the following issue in jetty: jetty/jetty.project#12913. |
|
Hello @OptimumCode , I would like to ask about the status. Is there something on your list of things left to do (except form the obvious failing checks)? I am thinking to maybe contribute a bit if I could in a way |
|
Hi, @olindenaus, the help would be very welcome) I haven't had much free time recently to continue looking into the PR, unfortunately... First of all, the new Jetty version was released, and it contains a fix for jetty/jetty.project#12913. We should see fewer failing tests. The rest of the problematic places can be found in the PR description (unfortunately, I have not had time to look closely at all of them). I think the one that causes the most test cases to fail is the cookies problem - the old approach to remove them does not work anymore. The test client (which is reused between tests) keeps cookies from previous tests, and it causes failures. |
|
Hello @OptimumCode, thanks for your reply, I will try to contribute when I find some free time during these days. |
PR continues from where @tipsy stopped. I have managed to make javalin main module compile however, there are several issues that remain:
org.eclipse.jetty.ee10.servlet.ServletContextRequest.getServletContextRequest(ServletRequest)and then useorg.eclipse.jetty.server.CookieCache.getCookies(Request)we can get cookies from upgrade requesta few issues related to URI compliance (when multiple slashes are used in request - have not looked closely at this yet)PR is based on #2158
Relates to #2067