This repository was archived by the owner on Oct 6, 2023. It is now read-only.
msf: don't put free page map blocks in a stream's list of blocks#14
Merged
jasonwhite merged 1 commit intojasonwhite:masterfrom Jun 22, 2018
Merged
msf: don't put free page map blocks in a stream's list of blocks#14jasonwhite merged 1 commit intojasonwhite:masterfrom
jasonwhite merged 1 commit intojasonwhite:masterfrom
Conversation
Owner
|
Great find! I guess I hadn't tested this on any PDBs that had large enough streams. I found myself a 2 GB PDB and verified your fix. Thanks for the PR and the detailed explanation! I'll merge this and make a new release. |
Owner
|
New release published: https://github.com/jasonwhite/ducible/releases/tag/v1.2.1 Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a large pdb that was getting corrupted by ducible. Even pdbdump would complain about the corruption after ducible was done processing it.
Basically my pdb has a stream in it that is long enough that it would be interrupted by a FPM block, and can't be stored contiguously in the pdb file. But ducible was trying anyway:
AIUI, it shouldn't be possible for such a large contiguous stream to exist in a pdb file, and the original file seemed to show this:
It looked like the free page map blocks were getting included in the stream's block list, which messed everything up. It seems that the FPM blocks are implicit and don't need to be written into any stream's block list.
This change fixes things for me, but I don't claim to fully understand everything about the code or the file format.
This tool is awesome! Thanks for developing it!