Move SOS to SDK build#15
Merged
jashook merged 2 commits intojashook:arcade_spc_buildfrom Mar 18, 2019
Merged
Conversation
swaroop-sridhar
commented
Mar 18, 2019
- Add RestoreArcade target and some other properties to SOS NETCore project
- Remove the hack to Skip SoS for arcade builds
* Add RestoreArcade target and some other properties to SOS NETCore project * Remove the hack to Skip SoS for arcade builds
Author
|
The build phase goes through, overall build fails in packaging. |
jashook
approved these changes
Mar 18, 2019
Owner
jashook
left a comment
There was a problem hiding this comment.
lgtm other than the redundant rootbindir
| <TargetFramework>netcoreapp1.0</TargetFramework> | ||
| <TargetFrameworkIdentifier>.NETCoreApp</TargetFrameworkIdentifier> | ||
| <PackageTargetFallback>$(PackageTargetFallback);portable-net45+win8</PackageTargetFallback> | ||
| <RootBinDir Condition="'$(__RootBinDir)'==''">$(ProjectDir)bin\</RootBinDir> |
Owner
There was a problem hiding this comment.
This should already be set in dir.props
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.