Fix #5086: Don’t generate unnecessary interpolations in JSX tags around herecomments #5108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tags when the tags contain only here (`/* ... */`) comments
|
Yes the test output looks correct. I tested this PR against a few examples I had, but admittedly I abandoned this approach of comment annotating a month or so back so I don't have many examples. I didn't hit any issues with what I do have. Thank you for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5086: Don’t generate unnecessary interpolations in JSX tags when the tags contain only here (
/* ... */) comments.@ryansolid can you please verify this against your codebase? And please look at https://github.com/GeoffreyBooth/coffeescript/blob/22ec8d91d81a6f22e8a8fe073b52d69419fe630e/test/csx.coffee#L745-L784 and let me know if the expected output is correct. I copied from your issue.