Skip to content

Fix5004: incorrect compiled code when a destructuring array contains accessors #5005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GeoffreyBooth merged 1 commit into from
Mar 7, 2018
Merged

Fix5004: incorrect compiled code when a destructuring array contains accessors #5005

GeoffreyBooth merged 1 commit into from
Mar 7, 2018

Conversation

@zdenko
Copy link
Collaborator

@zdenko zdenko commented Mar 5, 2018

Fixes #5004.

[@all_but_last_two... , @penultimate, @last] = array

###
[...this.all_but_last_two] = array, [this.penultimate, this.last] = splice.call(this.all_but_last_two, -2);
###
[obj.first , obj.middle..., obj.last] = array

###
[obj.first, ...obj.middle] = array, [obj.last] = splice.call(obj.middle, -1);
###

@GeoffreyBooth GeoffreyBooth merged commit 4c0363f into jashkenas:master Mar 7, 2018
@GeoffreyBooth GeoffreyBooth mentioned this pull request Mar 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nodes: array destructuring is broken in some cases and leads to TypeError

2 participants

@zdenko @GeoffreyBooth