Skip to content

Fix #4898: Lexer: backslash line continuation is inconsistent #4899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GeoffreyBooth merged 1 commit into from
Feb 18, 2018
Merged

Fix #4898: Lexer: backslash line continuation is inconsistent #4899

GeoffreyBooth merged 1 commit into from
Feb 18, 2018

Conversation

@zdenko
Copy link
Collaborator

@zdenko zdenko commented Feb 17, 2018

Fixes #4898. When indent line is ended with the backslash, Lexer incorrectly sets indentation levels.

if ( \
      false \
      or \
      true \
    )
    42

###
if (false || true) {
  42;
}
###
if ( \
    false \
    or \
    true \
)
  42

###
if (false || true) {
  42;
}
###

@GeoffreyBooth
Copy link
Collaborator

GeoffreyBooth commented Feb 17, 2018

Well this is a pretty clean fix. @vendethiel and @Inve1951?

@vendethiel
Copy link
Collaborator

vendethiel commented Feb 17, 2018

Just wondering how many other places that unless will have to appear at ;-).

@GeoffreyBooth GeoffreyBooth merged commit eb70092 into jashkenas:master Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zdenko @GeoffreyBooth @vendethiel