Skip to content

1.12.7 #4617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GeoffreyBooth merged 7 commits into from
Jul 17, 2017
Merged

1.12.7 #4617

GeoffreyBooth merged 7 commits into from
Jul 17, 2017

Conversation

@GeoffreyBooth
Copy link
Collaborator

@GeoffreyBooth GeoffreyBooth commented Jul 15, 2017

Tiny release, but I guess we’re not expecting any other 1.x updates anytime soon so might as well get these fixes out there.

@GeoffreyBooth GeoffreyBooth requested a review from lydell July 15, 2017 03:30
@GeoffreyBooth
Copy link
Collaborator Author

GeoffreyBooth commented Jul 15, 2017 •
edited
Loading

@lydell One last quick fix: c83c47d. I assume you’re okay with that? It gets the tests passing in Node 4.8.2, fixing #4610. If people are treating 1.x as our LTS release to go with Node’s oldest LTS, we probably should try not to break that (especially when it’s this easy).

@GeoffreyBooth GeoffreyBooth merged commit 27f21a3 into jashkenas:master Jul 17, 2017
@GeoffreyBooth GeoffreyBooth deleted the 1.12.7 branch July 17, 2017 06:59
@GeoffreyBooth
Copy link
Collaborator Author

GeoffreyBooth commented Jul 17, 2017

@helixbass do you mind please merging master into 2 and resolving conflicts? (Or submitting a PR for that)? I tried, but it’s a bit confusing since some of the bugs you fixed on master you also submitted PRs into 2 for. I’m not sure how to resolve the conflicts and get all the tests to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lydell lydell lydell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GeoffreyBooth @connec @lydell