Fix stats overcounting on key updates in set/mset methods #1531
+234
−156
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
setandmsetmethods unconditionally incremented the stats count, causing overcounting when updating existing keys instead of creating new ones.Changes
setmethod: Check key existence viakeyv.has()before incrementing countmsetmethod: Batch check keys viakeyv.hasMany()and increment count only for new keystakemethod: Fix incorrect method names (recordHit/recordMiss→incrementHits/incrementMisses)Example
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.