Upgrade engines.node to >=12 in package.json for basic template#733
Upgrade engines.node to >=12 in package.json for basic template#733zenflow wants to merge 1 commit into
Conversation
|
I appreciate that you were looking for some consistency here, but I'm sorry to say that I'll have to decline the PR in its current state. The current GitHub Action was meant to just be a starting point and not the end state. The action in each template is also meant to be the same; it's a limitation of our current templating set-up that there are multiple files. Node 10 is still LTS for another year, until May 2021, so I would certainly not recommend library authors only support Node 12+. It would be better to add matrix testing for different Node versions and OSes like TSDX itself does, which is likely to be added in the near future. |
The
engines.nodefield should match the version of node we are testing against in CI: https://github.com/jaredpalmer/tsdx/blob/21893b8e498985879bb6665dba279cf4853aabec/templates/basic/.github/workflows/main.ymlThis change doesn't apply to the other templates
Thanks for the awesome package! You saved me a ton of time for sure! <3