Skip to content

docs(readme): specify Jest v24 is used. Clarify jsdom flag#68

Merged
jaredpalmer merged 1 commit into
jaredpalmer:masterfrom
skvale:docs/jest-24
May 1, 2019
Merged

docs(readme): specify Jest v24 is used. Clarify jsdom flag#68
jaredpalmer merged 1 commit into
jaredpalmer:masterfrom
skvale:docs/jest-24

Conversation

@skvale

@skvale skvale commented May 1, 2019

Copy link
Copy Markdown
Contributor

This is using Jest v24 not v23.

From the create command:

        scripts: {
          start: 'tsdx watch',
          build: 'tsdx build',
          test: template === 'react' ? 'tsdx test --env=jsdom' : 'tsdx test',

So it's wasn't necessary to say

If you are trying to test a React component, you likely want to pass in --env=jsdom just like you do in Create React App

Proposed:

If you are using the React template, jest uses the flag --env=jsdom by default.

@jaredpalmer jaredpalmer merged commit 1087983 into jaredpalmer:master May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants