(feat): add --preserveModules flag#535
Draft
agilgur5 wants to merge 1 commit into
Draft
Conversation
- this works the same way as Rollup's preserveModules option, leaving
the module structure and not bundling any files together
- format, env, and minify are used as directories instead of filename
suffixes since the filename can't be changed without configuring
output.entryFileNames (possibly a future improvement?)
fc98ceb to
97c7e41
Compare
Collaborator
Author
|
I'm thinking that -- in the future as it would be very breaking -- it might make sense to have TSDX eventually use |
This was referenced Mar 4, 2020
Closed
This was referenced Apr 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the module structure and not bundling any files together
suffixes since the filename can't be changed without configuring
output.entryFileNames (possibly a future improvement?)
Fixes #276, fixes #299, fixes #321 .
Might fix ##382 , but need to think about what to do with
index.js.Related to #367, #175, #365, #425
Things to Review / TODOs:
declarationDir(conflicts/depends on (fix): declarationMaps (*.d.ts.map) should have correctsources#488) and then not producing types multiple times (conflicts/depends on (fix): multiple entries should output multiple bundles #367)dist/index.jsis still created. I'm not sure if it still makes sense to have (related to Ability to disable creating CJSdist/index.jsfile #382). If it does, its content needs to be modified (conflicts/depends on (fix): multiple entries should output multiple bundles #367) and maybe its location should be changed todist/cjs/index.js?