(fix): ensure Babel presets are merged#473
Merged
Merged
Conversation
- previously, if preset-env were not found in the user's presets, their presets would be overwritten by a single preset-env entry - now it properly merges their presets with an entry for preset-env
This was referenced Jan 30, 2020
Merged
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
their presets would be overwritten by a single preset-env entry
Fixes #443
I think this is good, but still need to create a test set-up for custom Babel configs. This requires installing some dependencies for automated tests. The
withConfigtsdx.config.jsfixture also requires installing some deps for automated tests and is currently a manual test (which means it isn't tested frequently -- I haven't tested it once in all my PRs), so would like to get that to be auto too.