Integrate new Storybook 5.3+ config & docs add-on#435
Merged
jaredpalmer merged 3 commits intoJan 21, 2020
Conversation
swyxio
approved these changes
Jan 21, 2020
swyxio
left a comment
Collaborator
There was a problem hiding this comment.
sick! you rock kyle. idk if @jaredpalmer or @agilgur5 have any other opinions but otherwise this LGTM
Owner
|
Merge it |
Collaborator
|
thanks for the great PR! @all-contributors please add @kylemh for code, examples and tests |
Contributor
|
I've put up a pull request to add @kylemh! 🎉 |
This was referenced Feb 28, 2020
This was referenced Apr 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #430
Resolves #431
I noticed in #318 Swyx asked for the docs addon, so I went ahead and integrated it.
Resolving 430 is crystal clear, but 431 I didn't see why it was ever implemented in the first place and have simply taken it out.