Open
Conversation
Jared made a great example! I tried to tune it in a little more, and use some more already available (but updated) functions like `group` and `contains` and `unpack`. He also proposed intersection\by and sort\by , which I added to Rye, but didn't use here at the end. Maybe he can and make code even nicer :)
jaredkrinke
reviewed
Jan 22, 2025
| ; Find anagrams from words file and keep transformations only | ||
| word-anagrams: | ||
| ( split\quoted read %0098_words.txt "," `"` ) | ||
| split\quoted read %0098_words.txt "," `"` ;" |
Author
There was a problem hiding this comment.
No :) .... Emacs Rye syntax highlighting did't detect the end of the string with "so it colored all next lines as string, this comment was small hack to stop that. I need to fix the highlighter.
Owner
|
Thanks! That looks like it's taking much better advantage of the built-ins! |
Author
Well, I did have to improve some of them (make them usable with blocks not just string for example) to make them usable here, so when you wrote the code you couldn't use them yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You made a great Rye example! I just tried to tune it in a little more, and use some more already available (but some updated) functions like
groupandcontainsandunpack.You also proposed
intersection\byandsort\by, which I added to Rye now, but didn't use here at the end. Maybe because I still don't fully understand the algo :P. I think I understand everything, but that part about transformation related to possible squares eludes me, probably I need to do some more thinking :)Anyhow, you said that we can post these and you will keep the PR open as additional info to examples. Great project!