Remove extra line after imports in conf.py#147
Merged
jaraco merged 1 commit intojaraco:mainfrom Sep 11, 2024
Merged
Conversation
This change fixes an incompatibility (and source of merge conflicts) with projects using Ruff/isort.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes an incompatibility (and source of merge conflicts) with projects using Ruff/isort.
I could add the
I(https://docs.astral.sh/ruff/rules/#isort-i) category to the Ruff configs (see example from https://github.com/pypa/setuptools/blob/962835d068af4d993f2195e7a6ffd4f70548b9f4/ruff.toml#L60-L62 ). But it would create more conflicts with ongoing #143 .But at the same time, a lot of those PRs already have conflicts from changes in
mypy.iniandconf.py, and import-related conflicts are easy to fix (accept both + rerun fixer). So maybe now's not a bad time to add it before I fix conflicts.