-
Notifications
You must be signed in to change notification settings - Fork 38
Apply Scientific Python repo-review suggestions #112
Copy link
Copy link
Open
Description
Apply those rules that make sense:
https://learn.scientific-python.org/development/guides/repo-review/?repo=jaraco%2Fskeleton&branch=main
Suggestions:
GH102: Auto-cancel on repeated PRs
At least one workflow should auto-cancel.
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: truePC100: Has pre-commit-hooks
Must have https://github.com/pre-commit/pre-commit-hooks repo in .pre-commit-config.yaml
PC901: Custom pre-commit CI message
Should have something like this in .pre-commit-config.yaml:
ci:
autoupdate_commit_msg: 'chore: update pre-commit hooks'RF101: Bugbear must be selected
Must select the flake8-bugbear B checks. Recommended:
[tool.ruff.lint]
extend-select = [
"B", # flake8-bugbear
]RF102: isort must be selected
Must select the isort I checks. Recommended:
[tool.ruff.lint]
extend-select = [
"I", # isort
]RF103: pyupgrade must be selected
Must select the pyupgrade UP checks. Recommended:
[tool.ruff.lint]
extend-select = [
"UP", # pyupgrade
]Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels