Apply :flycheck on def as well#1681
Conversation
Signed-off-by: Tw <tw19881113@gmail.com> Change-Id: I7bd10cbaa838b44794f8a881b0deedd06a6a6964
|
I'm still familiarizing myself with janet's Any hints about what I guess that On a side note, I think the CI thing may be similar to what's described here: janet-lang/spork#258. I've made a separate PR for that here. |
I originally regard it as
Yep. |
|
Thanks for the clarification. FWIW, it seems like there is precedent for |
|
Looks pretty good to me, good for one off fixes to make things pass flychecking. |
This is actually motivated by the investigation on janet-lang/spork#264.
With this change, we could also allow user to do something like this:
If they believe
maybe-side-effect-funcwon't cause any harm during flycheck.