Use strnlen when checking for null byte#1601
Merged
bakpakin merged 1 commit intojanet-lang:masterfrom Jun 14, 2025
Merged
Conversation
Member
|
Looks good. Most places where we convert buffers to strings, we should be calling |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buffers are not always null-terminated, so using
strlenhere could cause reads past the end of the buffer and cause Janet to incorrectly report that the string contains zeros because the lengths don't match.There may be other instances to fix, but this fixes #1600.