Fix mapcat and keep docstrings#1581
Merged
bakpakin merged 1 commit intojanet-lang:masterfrom Apr 8, 2025
Merged
Conversation
Member
|
No problem, I appreciate the help with making the docstrings more precise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, I think I messed up the
mapcatandkeepdocstrings in #1578.For
mapcatthe docstring said:This is not correct, as shown by this example:
This PR suggests instead the text:
For
keep, the docstring said:This is not necessarily correct, as shown by this example:
This PR suggests instead the text:
Hopefully, the above suggestions correct the errors.
(Sorry about the mess up with #1580 as well.)